Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Deprecate positional arguments in tree module #16966

Merged
merged 3 commits into from Apr 22, 2020
Merged

API Deprecate positional arguments in tree module #16966

merged 3 commits into from Apr 22, 2020

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Toward #15005

What does this implement/fix? Explain your changes.

I am working backwards from the list.

CC @adrinjalali

adrinjalali
adrinjalali reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are failing due to internal positional usage.

@thomasjpfan thomasjpfan added this to the 0.23 milestone Apr 20, 2020
jnothman
jnothman approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should consider allowing positional criterion. They tend to be unambiguous.

@thomasjpfan
Copy link
Member Author

I would prefer to make criterion keyword only here to be consistent with RandomForest* which makes criterion keyword only.

@NicolasHug NicolasHug merged commit 388999b into scikit-learn:master Apr 22, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@thomasjpfan @gio8tisu
API Deprecate positional arguments in tree module (scikit-learn#16966)
a6216ba
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@thomasjpfan @viclafargue
API Deprecate positional arguments in tree module (scikit-learn#16966)
eee3956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:tree
Projects
None yet
Milestone
0.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thomasjpfan @jnothman @adrinjalali @NicolasHug