Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Adds permute_y to make_classification interaction #17052

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Fixes #16789

What does this implement/fix? Explain your changes.

Permutes the labels instead of generating new labels.

Any other comments?

Not backward compatible.

@jnothman
Copy link
Member

I think this is a somewhat different meaning of flip_y, albeit a more intuitive meaning of that name. Should this be a different param?

@tianchuliang
Copy link
Contributor

Maybe making this as an additional param, such as permute_y? Otherwise this is backward in-compatible with flip_y.

@thomasjpfan
Copy link
Member Author

I think a boolean flip_y_permutes=False, which controls the behavior of flip_y looks okay.

Base automatically changed from master to main January 22, 2021 10:52
@thomasjpfan thomasjpfan changed the title BUG Fixes make_classification interaction between flip_y and n_classes ENH Adds permute_y to make_classification interaction Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter n_classes in make_classification does not work as expected in extreme cases.
3 participants