Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better code formatting #17190

Closed

Conversation

KumarGanesha1996
Copy link

hi i improve code formatting in project using https://github.com/google/yapf.

KumarGanesha1996 and others added 3 commits May 11, 2020 19:24
 Please enter the commit message for your changes. Lines starting
 with '#' will be ignored, and an empty message aborts the commit.

 On branch kumar-fix
 Your branch is up to date with 'origin/kumar-fix'.

 Changes to be committed:
	modified:   conftest.py
	modified:   setup.py
	modified:   sklearn/__check_build/__init__.py
	modified:   sklearn/__check_build/setup.py
	modified:   sklearn/__init__.py
	modified:   sklearn/_build_utils/__init__.py
	modified:   sklearn/_build_utils/deprecated_modules.py
	modified:   sklearn/_build_utils/openmp_helpers.py
	modified:   sklearn/_build_utils/pre_build_helpers.py
	modified:   sklearn/_config.py
	modified:   sklearn/_loss/glm_distribution.py
	modified:   sklearn/_loss/tests/test_glm_distribution.py
	modified:   sklearn/base.py
	modified:   sklearn/calibration.py
	modified:   sklearn/cluster/__init__.py
	modified:   sklearn/cluster/_affinity_propagation.py
	modified:   sklearn/cluster/_agglomerative.py
	modified:   sklearn/cluster/_bicluster.py
	modified:   sklearn/cluster/_birch.py
	modified:   sklearn/cluster/_dbscan.py
	modified:   sklearn/cluster/_feature_agglomeration.py
	modified:   sklearn/cluster/_kmeans.py
	modified:   sklearn/cluster/_mean_shift.py
	modified:   sklearn/cluster/_optics.py
	modified:   sklearn/cluster/_spectral.py
	modified:   sklearn/cluster/tests/common.py
	modified:   sklearn/cluster/tests/test_affinity_propagation.py
	modified:   sklearn/cluster/tests/test_bicluster.py
	modified:   sklearn/cluster/tests/test_birch.py
	modified:   sklearn/cluster/tests/test_dbscan.py
	modified:   sklearn/cluster/tests/test_feature_agglomeration.py
	modified:   sklearn/cluster/tests/test_hierarchical.py
	modified:   sklearn/cluster/tests/test_k_means.py
	modified:   sklearn/cluster/tests/test_mean_shift.py
	modified:   sklearn/cluster/tests/test_optics.py
	modified:   sklearn/cluster/tests/test_spectral.py
	modified:   sklearn/compose/__init__.py
	modified:   sklearn/compose/_column_transformer.py
	modified:   sklearn/compose/_target.py
	modified:   sklearn/compose/tests/test_column_transformer.py
	modified:   sklearn/compose/tests/test_target.py
	modified:   sklearn/covariance/__init__.py
	modified:   sklearn/covariance/_elliptic_envelope.py
	modified:   sklearn/covariance/_empirical_covariance.py
	modified:   sklearn/covariance/_graph_lasso.py
	modified:   sklearn/covariance/_robust_covariance.py
	modified:   sklearn/covariance/_shrunk_covariance.py
	modified:   sklearn/covariance/tests/test_covariance.py
	modified:   sklearn/covariance/tests/test_elliptic_envelope.py
	modified:   sklearn/covariance/tests/test_graphical_lasso.py
	modified:   sklearn/covariance/tests/test_robust_covariance.py
	modified:   sklearn/cross_decomposition/_cca.py
	modified:   sklearn/cross_decomposition/_pls.py
	modified:   sklearn/cross_decomposition/tests/test_pls.py
	modified:   sklearn/datasets/__init__.py
	modified:   sklearn/datasets/_base.py
	modified:   sklearn/datasets/_california_housing.py
	modified:   sklearn/datasets/_covtype.py
	modified:   sklearn/datasets/_kddcup99.py
	modified:   sklearn/datasets/_lfw.py
	modified:   sklearn/datasets/_olivetti_faces.py
	modified:   sklearn/datasets/_openml.py
	modified:   sklearn/datasets/_rcv1.py
	modified:   sklearn/datasets/_samples_generator.py
	modified:   sklearn/datasets/_species_distributions.py
	modified:   sklearn/datasets/_svmlight_format_io.py
	modified:   sklearn/datasets/_twenty_newsgroups.py
	modified:   sklearn/datasets/setup.py
	modified:   sklearn/datasets/tests/conftest.py
	modified:   sklearn/datasets/tests/test_20news.py
	modified:   sklearn/datasets/tests/test_base.py
	modified:   sklearn/datasets/tests/test_california_housing.py
	modified:   sklearn/datasets/tests/test_common.py
	modified:   sklearn/datasets/tests/test_covtype.py
	modified:   sklearn/datasets/tests/test_kddcup99.py
	modified:   sklearn/datasets/tests/test_lfw.py
	modified:   sklearn/datasets/tests/test_olivetti_faces.py
	modified:   sklearn/datasets/tests/test_openml.py
	modified:   sklearn/datasets/tests/test_rcv1.py
	modified:   sklearn/datasets/tests/test_samples_generator.py
	modified:   sklearn/datasets/tests/test_svmlight_format.py
	modified:   sklearn/decomposition/__init__.py
	modified:   sklearn/decomposition/_base.py
	modified:   sklearn/decomposition/_dict_learning.py
	modified:   sklearn/decomposition/_factor_analysis.py
	modified:   sklearn/decomposition/_fastica.py
	modified:   sklearn/decomposition/_incremental_pca.py
	modified:   sklearn/decomposition/_kernel_pca.py
	modified:   sklearn/decomposition/_lda.py
	modified:   sklearn/decomposition/_nmf.py
	modified:   sklearn/decomposition/_pca.py
	modified:   sklearn/decomposition/_sparse_pca.py
	modified:   sklearn/decomposition/_truncated_svd.py
	modified:   sklearn/decomposition/setup.py
	modified:   sklearn/decomposition/tests/test_dict_learning.py
	modified:   sklearn/decomposition/tests/test_factor_analysis.py
	modified:   sklearn/decomposition/tests/test_fastica.py
	modified:   sklearn/decomposition/tests/test_incremental_pca.py
	modified:   sklearn/decomposition/tests/test_kernel_pca.py
	modified:   sklearn/decomposition/tests/test_nmf.py
	modified:   sklearn/decomposition/tests/test_online_lda.py
	modified:   sklearn/decomposition/tests/test_pca.py
	modified:   sklearn/decomposition/tests/test_sparse_pca.py
	modified:   sklearn/decomposition/tests/test_truncated_svd.py
	modified:   sklearn/discriminant_analysis.py
	modified:   sklearn/dummy.py
	modified:   sklearn/ensemble/__init__.py
	modified:   sklearn/ensemble/_bagging.py
	modified:   sklearn/ensemble/_base.py
	modified:   sklearn/ensemble/_forest.py
	modified:   sklearn/ensemble/_gb.py
	modified:   sklearn/ensemble/_gb_losses.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/binning.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/grower.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/loss.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_binning.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_compare_lightgbm.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_gradient_boosting.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_grower.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_histogram.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_loss.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_monotonic_contraints.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_predictor.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_splitting.py
	modified:   sklearn/ensemble/_hist_gradient_boosting/tests/test_warm_start.py
	modified:   sklearn/ensemble/_iforest.py
	modified:   sklearn/ensemble/_stacking.py
	modified:   sklearn/ensemble/_voting.py
	modified:   sklearn/ensemble/_weight_boosting.py
	modified:   sklearn/ensemble/setup.py
	modified:   sklearn/ensemble/tests/test_bagging.py
	modified:   sklearn/ensemble/tests/test_base.py
	modified:   sklearn/ensemble/tests/test_common.py
	modified:   sklearn/ensemble/tests/test_forest.py
	modified:   sklearn/ensemble/tests/test_gradient_boosting.py
	modified:   sklearn/ensemble/tests/test_gradient_boosting_loss_functions.py
	modified:   sklearn/ensemble/tests/test_iforest.py
	modified:   sklearn/ensemble/tests/test_stacking.py
	modified:   sklearn/ensemble/tests/test_voting.py
	modified:   sklearn/ensemble/tests/test_weight_boosting.py
	modified:   sklearn/exceptions.py
	modified:   sklearn/experimental/enable_hist_gradient_boosting.py
	modified:   sklearn/externals/__init__.py
	modified:   sklearn/externals/_arff.py
	modified:   sklearn/externals/_lobpcg.py
	modified:   sklearn/externals/_pep562.py
	modified:   sklearn/externals/_pilutil.py
	modified:   sklearn/externals/conftest.py
	modified:   sklearn/feature_extraction/__init__.py
	modified:   sklearn/feature_extraction/_dict_vectorizer.py
	modified:   sklearn/feature_extraction/_hash.py
	modified:   sklearn/feature_extraction/_stop_words.py
	modified:   sklearn/feature_extraction/image.py
	modified:   sklearn/feature_extraction/tests/test_dict_vectorizer.py
	modified:   sklearn/feature_extraction/tests/test_feature_hasher.py
	modified:   sklearn/feature_extraction/tests/test_image.py
	modified:   sklearn/feature_extraction/tests/test_text.py
	modified:   sklearn/feature_extraction/text.py
	modified:   sklearn/feature_selection/__init__.py
	modified:   sklearn/feature_selection/_base.py
	modified:   sklearn/feature_selection/_from_model.py
	modified:   sklearn/feature_selection/_mutual_info.py
	modified:   sklearn/feature_selection/_rfe.py
	modified:   sklearn/feature_selection/_univariate_selection.py
	modified:   sklearn/feature_selection/_variance_threshold.py
	modified:   sklearn/feature_selection/tests/test_base.py
	modified:   sklearn/feature_selection/tests/test_chi2.py
	modified:   sklearn/feature_selection/tests/test_feature_select.py
	modified:   sklearn/feature_selection/tests/test_from_model.py
	modified:   sklearn/feature_selection/tests/test_mutual_info.py
	modified:   sklearn/feature_selection/tests/test_rfe.py
	modified:   sklearn/feature_selection/tests/test_variance_threshold.py
	modified:   sklearn/gaussian_process/__init__.py
	modified:   sklearn/gaussian_process/_gpc.py
	modified:   sklearn/gaussian_process/_gpr.py
	modified:   sklearn/gaussian_process/kernels.py
	modified:   sklearn/gaussian_process/tests/_mini_sequence_kernel.py
	modified:   sklearn/gaussian_process/tests/test_gpc.py
	modified:   sklearn/gaussian_process/tests/test_gpr.py
	modified:   sklearn/gaussian_process/tests/test_kernels.py
	modified:   sklearn/impute/__init__.py
	modified:   sklearn/impute/_base.py
	modified:   sklearn/impute/_iterative.py
	modified:   sklearn/impute/_knn.py
	modified:   sklearn/impute/tests/test_common.py
	modified:   sklearn/impute/tests/test_impute.py
	modified:   sklearn/impute/tests/test_knn.py
	modified:   sklearn/inspection/__init__.py
	modified:   sklearn/inspection/_partial_dependence.py
	modified:   sklearn/inspection/_permutation_importance.py
	modified:   sklearn/inspection/_plot/partial_dependence.py
	modified:   sklearn/inspection/_plot/tests/test_plot_partial_dependence.py
	modified:   sklearn/inspection/tests/test_partial_dependence.py
	modified:   sklearn/inspection/tests/test_permutation_importance.py
	modified:   sklearn/isotonic.py
	modified:   sklearn/kernel_approximation.py
	modified:   sklearn/kernel_ridge.py
	modified:   sklearn/linear_model/__init__.py
	modified:   sklearn/linear_model/_base.py
	modified:   sklearn/linear_model/_bayes.py
	modified:   sklearn/linear_model/_coordinate_descent.py
	modified:   sklearn/linear_model/_glm/__init__.py
	modified:   sklearn/linear_model/_glm/glm.py
	modified:   sklearn/linear_model/_glm/link.py
	modified:   sklearn/linear_model/_glm/tests/test_glm.py
	modified:   sklearn/linear_model/_glm/tests/test_link.py
	modified:   sklearn/linear_model/_huber.py
	modified:   sklearn/linear_model/_least_angle.py
	modified:   sklearn/linear_model/_logistic.py
	modified:   sklearn/linear_model/_omp.py
	modified:   sklearn/linear_model/_passive_aggressive.py
	modified:   sklearn/linear_model/_perceptron.py
	modified:   sklearn/linear_model/_ransac.py
	modified:   sklearn/linear_model/_ridge.py
	modified:   sklearn/linear_model/_sag.py
	modified:   sklearn/linear_model/_stochastic_gradient.py
	modified:   sklearn/linear_model/_theil_sen.py
	modified:   sklearn/linear_model/tests/test_base.py
	modified:   sklearn/linear_model/tests/test_bayes.py
	modified:   sklearn/linear_model/tests/test_coordinate_descent.py
	modified:   sklearn/linear_model/tests/test_huber.py
	modified:   sklearn/linear_model/tests/test_least_angle.py
	modified:   sklearn/linear_model/tests/test_logistic.py
	modified:   sklearn/linear_model/tests/test_omp.py
	modified:   sklearn/linear_model/tests/test_passive_aggressive.py
	modified:   sklearn/linear_model/tests/test_perceptron.py
	modified:   sklearn/linear_model/tests/test_ransac.py
	modified:   sklearn/linear_model/tests/test_ridge.py
	modified:   sklearn/linear_model/tests/test_sag.py
	modified:   sklearn/linear_model/tests/test_sgd.py
	modified:   sklearn/linear_model/tests/test_sparse_coordinate_descent.py
	modified:   sklearn/linear_model/tests/test_theil_sen.py
	modified:   sklearn/manifold/__init__.py
	modified:   sklearn/manifold/_isomap.py
	modified:   sklearn/manifold/_locally_linear.py
	modified:   sklearn/manifold/_mds.py
	modified:   sklearn/manifold/_spectral_embedding.py
	modified:   sklearn/manifold/_t_sne.py
	modified:   sklearn/manifold/tests/test_isomap.py
	modified:   sklearn/manifold/tests/test_locally_linear.py
	modified:   sklearn/manifold/tests/test_mds.py
	modified:   sklearn/manifold/tests/test_spectral_embedding.py
	modified:   sklearn/manifold/tests/test_t_sne.py
	modified:   sklearn/metrics/__init__.py
	modified:   sklearn/metrics/_base.py
	modified:   sklearn/metrics/_classification.py
	modified:   sklearn/metrics/_plot/base.py
	modified:   sklearn/metrics/_plot/confusion_matrix.py
	modified:   sklearn/metrics/_plot/precision_recall_curve.py
	modified:   sklearn/metrics/_plot/roc_curve.py
	modified:   sklearn/metrics/_plot/tests/test_plot_confusion_matrix.py
	modified:   sklearn/metrics/_plot/tests/test_plot_precision_recall.py
	modified:   sklearn/metrics/_plot/tests/test_plot_roc_curve.py
	modified:   sklearn/metrics/_ranking.py
	modified:   sklearn/metrics/_regression.py
	modified:   sklearn/metrics/_scorer.py
	modified:   sklearn/metrics/cluster/__init__.py
	modified:   sklearn/metrics/cluster/_bicluster.py
	modified:   sklearn/metrics/cluster/_supervised.py
	modified:   sklearn/metrics/cluster/_unsupervised.py
	modified:   sklearn/metrics/cluster/tests/test_bicluster.py
	modified:   sklearn/metrics/cluster/tests/test_common.py
	modified:   sklearn/metrics/cluster/tests/test_supervised.py
	modified:   sklearn/metrics/cluster/tests/test_unsupervised.py
	modified:   sklearn/metrics/pairwise.py
	modified:   sklearn/metrics/tests/test_classification.py
	modified:   sklearn/metrics/tests/test_common.py
	modified:   sklearn/metrics/tests/test_pairwise.py
	modified:   sklearn/metrics/tests/test_ranking.py
	modified:   sklearn/metrics/tests/test_regression.py
	modified:   sklearn/metrics/tests/test_score_objects.py
	modified:   sklearn/mixture/__init__.py
	modified:   sklearn/mixture/_base.py
	modified:   sklearn/mixture/_bayesian_mixture.py
	modified:   sklearn/mixture/_gaussian_mixture.py
	modified:   sklearn/mixture/tests/test_bayesian_mixture.py
	modified:   sklearn/mixture/tests/test_gaussian_mixture.py
	modified:   sklearn/mixture/tests/test_mixture.py
	modified:   sklearn/model_selection/__init__.py
	modified:   sklearn/model_selection/_search.py
	modified:   sklearn/model_selection/_split.py
	modified:   sklearn/model_selection/_validation.py
	modified:   sklearn/model_selection/tests/test_search.py
	modified:   sklearn/model_selection/tests/test_split.py
	modified:   sklearn/model_selection/tests/test_validation.py
	modified:   sklearn/multiclass.py
	modified:   sklearn/multioutput.py
	modified:   sklearn/naive_bayes.py
	modified:   sklearn/neighbors/_classification.py
	modified:   sklearn/neural_network/__init__.py
	modified:   sklearn/neural_network/_base.py
	modified:   sklearn/neural_network/_multilayer_perceptron.py
	modified:   sklearn/neural_network/_rbm.py
	modified:   sklearn/neural_network/_stochastic_optimizers.py
	modified:   sklearn/neural_network/tests/test_base.py
	modified:   sklearn/neural_network/tests/test_mlp.py
	modified:   sklearn/neural_network/tests/test_rbm.py
	modified:   sklearn/neural_network/tests/test_stochastic_optimizers.py
	modified:   sklearn/pipeline.py
	modified:   sklearn/preprocessing/__init__.py
	modified:   sklearn/preprocessing/_data.py
	modified:   sklearn/preprocessing/_discretization.py
	modified:   sklearn/preprocessing/_encoders.py
	modified:   sklearn/preprocessing/_function_transformer.py
	modified:   sklearn/preprocessing/_label.py
	modified:   sklearn/preprocessing/tests/test_common.py
	modified:   sklearn/preprocessing/tests/test_data.py
	modified:   sklearn/preprocessing/tests/test_discretization.py
	modified:   sklearn/preprocessing/tests/test_encoders.py
	modified:   sklearn/preprocessing/tests/test_function_transformer.py
	modified:   sklearn/preprocessing/tests/test_label.py
	modified:   sklearn/random_projection.py
	modified:   sklearn/semi_supervised/_label_propagation.py
	modified:   sklearn/semi_supervised/tests/test_label_propagation.py
	modified:   sklearn/setup.py
	modified:   sklearn/svm/__init__.py
	modified:   sklearn/svm/_base.py
	modified:   sklearn/svm/_bounds.py
	modified:   sklearn/svm/_classes.py
	modified:   sklearn/svm/setup.py
	modified:   sklearn/svm/tests/test_bounds.py
	modified:   sklearn/svm/tests/test_sparse.py
	modified:   sklearn/svm/tests/test_svm.py
	modified:   sklearn/tests/test_base.py
	modified:   sklearn/tests/test_build.py
	modified:   sklearn/tests/test_calibration.py
	modified:   sklearn/tests/test_common.py
	modified:   sklearn/tests/test_config.py
	modified:   sklearn/tests/test_discriminant_analysis.py
	modified:   sklearn/tests/test_docstring_parameters.py
	modified:   sklearn/tests/test_dummy.py
	modified:   sklearn/tests/test_import_deprecations.py
	modified:   sklearn/tests/test_init.py
	modified:   sklearn/tests/test_isotonic.py
	modified:   sklearn/tests/test_kernel_approximation.py
	modified:   sklearn/tests/test_kernel_ridge.py
	modified:   sklearn/tests/test_metaestimators.py
	modified:   sklearn/tests/test_multiclass.py
	modified:   sklearn/tests/test_multioutput.py
	modified:   sklearn/tests/test_naive_bayes.py
	modified:   sklearn/tests/test_pipeline.py
	modified:   sklearn/tests/test_random_projection.py
	modified:   sklearn/tree/__init__.py
	modified:   sklearn/tree/_classes.py
	modified:   sklearn/tree/_export.py
	modified:   sklearn/tree/_reingold_tilford.py
	modified:   sklearn/tree/setup.py
	modified:   sklearn/tree/tests/test_export.py
	modified:   sklearn/tree/tests/test_reingold_tilford.py
	modified:   sklearn/tree/tests/test_tree.py
	modified:   sklearn/utils/__init__.py
	modified:   sklearn/utils/_estimator_html_repr.py
	modified:   sklearn/utils/_joblib.py
	modified:   sklearn/utils/_mocking.py
	modified:   sklearn/utils/_pprint.py
	modified:   sklearn/utils/_testing.py
	modified:   sklearn/utils/class_weight.py
	modified:   sklearn/utils/deprecation.py
	modified:   sklearn/utils/estimator_checks.py
	modified:   sklearn/utils/extmath.py
	modified:   sklearn/utils/fixes.py
	modified:   sklearn/utils/graph.py
	modified:   sklearn/utils/metaestimators.py
	modified:   sklearn/utils/multiclass.py
	modified:   sklearn/utils/optimize.py
	modified:   sklearn/utils/random.py
	modified:   sklearn/utils/setup.py
	modified:   sklearn/utils/sparsefuncs.py
	modified:   sklearn/utils/stats.py
	modified:   sklearn/utils/tests/test_class_weight.py
	modified:   sklearn/utils/tests/test_cython_blas.py
	modified:   sklearn/utils/tests/test_deprecated_utils.py
	modified:   sklearn/utils/tests/test_deprecation.py
	modified:   sklearn/utils/tests/test_estimator_checks.py
	modified:   sklearn/utils/tests/test_estimator_html_repr.py
	modified:   sklearn/utils/tests/test_extmath.py
	modified:   sklearn/utils/tests/test_fixes.py
	modified:   sklearn/utils/tests/test_metaestimators.py
	modified:   sklearn/utils/tests/test_multiclass.py
	modified:   sklearn/utils/tests/test_murmurhash.py
	modified:   sklearn/utils/tests/test_optimize.py
	modified:   sklearn/utils/tests/test_pprint.py
	modified:   sklearn/utils/tests/test_random.py
	modified:   sklearn/utils/tests/test_seq_dataset.py
	modified:   sklearn/utils/tests/test_shortest_path.py
	modified:   sklearn/utils/tests/test_show_versions.py
	modified:   sklearn/utils/tests/test_sparsefuncs.py
	modified:   sklearn/utils/tests/test_testing.py
	modified:   sklearn/utils/tests/test_utils.py
	modified:   sklearn/utils/tests/test_validation.py
	modified:   sklearn/utils/validation.py
@NicolasHug
Copy link
Member

Sorry @KumarGanesha1996 ,

We can't consider such changes at the moment. We're sort of considering using black but it's not clear whether we even want it. See discussions at #11336

@rth
Copy link
Member

rth commented May 12, 2020

it's not clear whether we even want it.

I'm sure we do, we just might not know it yet :)

Closing sorry @KumarGanesha1996 , see #11336 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants