Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] remove default y value in sklearn.kernel_ridge.KernelRidge.fit #17906

Merged

Conversation

mikeaalv
Copy link
Contributor

Reference Issues/PRs

related to #17899

What does this implement/fix? Explain your changes.

This is regression function and so y need to be provided. Remove the None default value in sklearn.kernel_ridge.KernelRidge.fit

Any other comments?

None

@mikeaalv mikeaalv changed the title remove default y value in sklearn.kernel_ridge.KernelRidge.fit [MRG] remove default y value in sklearn.kernel_ridge.KernelRidge.fit Jul 11, 2020
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mikeaalv !

LGTM

@thomasjpfan thomasjpfan merged commit 993a0a3 into scikit-learn:master Jul 11, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants