[WIP] ENH create callable class to get adequate scorer for a problem #17930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Jan 18, 2021
|
|
||
| estimator = GridSearchCV( | ||
| DecisionTreeClassifier(), param_grid={"max_depth": [3, 5]}, | ||
| scoring=average_precision_scorer, |
There was a problem hiding this comment.
I had thought it should be possible to also just pass scoring=scorers. Does this work in the present PR?
There was a problem hiding this comment.
I assume no (I did not remember I had this PR). scorers should be a dict if we want to have multimetric
There was a problem hiding this comment.
Or, after #15126, scorers can be a callable that returns a dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17889
Alternative to #17889