Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST Default skip network tests in datatests' common tests #18002

Merged
merged 1 commit into from
Jul 27, 2020
Merged

TST Default skip network tests in datatests' common tests #18002

merged 1 commit into from
Jul 27, 2020

Conversation

thomasjpfan
Copy link
Member

Skips network tests by default for dataset common test.

CC @glemaitre

Related to #17996

rth
rth approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that should probably fix it. Thanks!

ogrisel
ogrisel approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add this env var in my local .bashrc to make sure I run the network tests locally.

@ogrisel ogrisel merged commit cb8f180 into scikit-learn:master Jul 27, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@thomasjpfan @jayzed82
TST Default skip network tests (scikit-learn#18002)
ff26633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
module:datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasjpfan @ogrisel @rth