Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Expand Brier score, fix docstring #18051

Merged
merged 7 commits into from Aug 13, 2020
Merged

DOC Expand Brier score, fix docstring #18051

merged 7 commits into from Aug 13, 2020

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

Follows from #10969 and issue #10883

What does this implement/fix? Explain your changes.

  • Expand Brier score explanation wrt calibration and refinement loss in the user guide

Fix brier_score_loss docstring:

  • Ambiguity in brier score doc fixed #10969 removed some blank lines, which removed the paragraph structure of the docstring. Added lines back here.
  • Link to brier score part of user guide and not calibration part
  • Correct pos_label description
  • Some minor rewording to make it easier to understand and more similar to the user guide.

Any other comments?

ogrisel
ogrisel reviewed Aug 6, 2020
View reviewed changes
doc/modules/model_evaluation.rst Outdated Show resolved Hide resolved
sklearn/metrics/_classification.py Show resolved Hide resolved
ogrisel
ogrisel approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

thomasjpfan
thomasjpfan approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As an aside, I found that this talk from Scipy 2019 was a nice overview of looking at brief score with 3 components.

@thomasjpfan thomasjpfan merged commit 854f649 into scikit-learn:master Aug 13, 2020
@lucyleeow lucyleeow deleted the doc_brier branch August 14, 2020 09:33
@lucyleeow
Copy link
Member Author

Thanks! (ribs!)

@lucyleeow lucyleeow mentioned this pull request Aug 14, 2020
Open
@lorentzenchr lorentzenchr mentioned this pull request Aug 15, 2020
Merged
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@lucyleeow @ogrisel @jayzed82
DOC Expand Brier score, fix docstring (scikit-learn#18051)
c1bb554 
* fix brier

* fix brier

* add ref

* add ref for lint

* Add link to PDF for calibration book chapter.

* Fix broken repeated ref by using qualified identifier

* Fix indentation

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucyleeow @ogrisel @thomasjpfan