MAINT fix fetch_kddcup99_fxt fixture #18519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_pandas_dependency_message would previously fail when run locally because the fake fetch_kddcup99_fxt dataset loading function would fail to expose the right function name used to build the expected error message. Note that this problem is not visible on the CI because we set SKLEARN_SKIP_NETWORK_TESTS=1 in our CI settings to limit bandwidth usage.
|
Duplicate of #18503. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_pandas_dependency_messagewould previously fail when runlocally because the fake
fetch_kddcup99_fxtdataset loadingfunction would fail to expose the right function name used
to build the expected error message.
Note that this problem is not visible on the CI because we set
SKLEARN_SKIP_NETWORK_TESTS=1in our CI settings to limit bandwidthusage.