FIX/MNT do not support OOB score for multiclass-multioutput and additional refactoring #19162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
changed the title
|
@ogrisel it should be OK now to have a first review. |
|
@thomasjpfan @ogrisel @NicolasHug @adrinjalali @amueller Do you want to have a look at this PR. This could be useful to further review the permutation importance using the OOB. |
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
ogrisel
approved these changes
Jan 21, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
ogrisel
reviewed
Jan 21, 2021
|
ping @adrinjalali for a second approval :) |
adrinjalali
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Thanks @glemaitre . LGTM, if you're not worried about the comment bellow, feel free to merge :)
Comment on lines
+458
to
+462
| else: | ||
| # for regression, n_classes_ does not exist and we create an empty | ||
| # axis to be consistent with the classification case and make | ||
| # the array operations compatible with the 2 settings | ||
| oob_pred_shape = (n_samples, 1, n_outputs) |
There was a problem hiding this comment.
hopefully there is no classifier out there which has an effective n_classes_ > 1 and yet not setting the right flag to say it's a classifier :D
There was a problem hiding this comment.
It should not pass our common test then I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the OOB scoring in forest.
TODO:
sklearndoes not have any metric for this case.