Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX validate handle_unkown strategies in OrdinalEncoder #19234

Merged
merged 3 commits into from Jan 22, 2021

Conversation

glemaitre
Copy link
Member

closes #19228

Check the strategy passed to handle_unknown in OrdinalEncoder.

@glemaitre glemaitre added To backport PR merged in master that need a backport to a release branch defined based on the milestone. module:preprocessing and removed module:preprocessing labels Jan 21, 2021
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @glemaitre

@jeremiedbb jeremiedbb merged commit 8ea176a into scikit-learn:master Jan 22, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:preprocessing To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrdinalEncoder does not check the input of handle_unknown
3 participants