DOC Ensures that RandomForestClassifier passes numpydoc validation #20383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Jun 26, 2021
|
#20385 has been merged. You can merge |
|
Uhm |
…ier_docstrings_pass_numpydoc_valid
|
We ran black after implementing the changes and merging main into our branch but there was no reformatting. |
glemaitre
reviewed
Jun 26, 2021
|
Yep black is not complaining anymore. However, my suggestion is too long. I propose to break the line and flake8 should be fine. |
glemaitre
reviewed
Jun 28, 2021
glemaitre
approved these changes
Jul 6, 2021
glemaitre
reviewed
Jul 7, 2021
glemaitre
reviewed
Jul 7, 2021
glemaitre
approved these changes
Jul 7, 2021
|
The CIs are green, let's merge. Thanks @alinealfa |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Jul 7, 2021
…cikit-learn#20383) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…cikit-learn#20383) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
Fixes numpydoc errors on RandomForestClassifier
Forces decorate property to update doc for deprecated method
Any other comments?
#DataUmbrella #sprint
cc. @marenwestermann