DOC Ensures BayesianGaussianMixture docstring passes numpydoc validation #20384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
changed the title
BayesianGaussianMixture
glemaitre
reviewed
Jun 26, 2021
|
@glemaitre i made the changes by myself because i don't understand the suggestion flow porposed. 🤷 |
glemaitre
reviewed
Jun 28, 2021
It is fine as well. Normally, you can go in the |
|
I just made a small change regarding the self type otherwise it looks good. Merging. Thanks @nicolas471 |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…ion (scikit-learn#20384) Co-authored-by: Nico Stefani <nicolas.stefani@mercadolibre.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
Fixes numpydoc errors on BayesianGaussianMixture functions
#DataUmbrella sprint
cc. @asnramos