DOC Ensures that OneHotEncoder passes numpydoc validation #20406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
approved these changes
Jun 27, 2021
sklearn/preprocessing/_encoders.py
Outdated
| @@ -449,7 +449,8 @@ def fit(self, X, y=None): | |||
|
|
|||
| Returns | |||
| ------- | |||
| self | |||
| self: | |||
There was a problem hiding this comment.
When there is no type associated, the : is not necessary https://numpydoc.readthedocs.io/en/latest/format.html#parameters
Suggested change
| self: | |
| self |
|
Updating with correct spelling: #DataUmbrella sprint |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…rn#20406) Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
This PR ensures
OneHotEncoderis compatible with numpydocdOneHotEncoderfromDOCSTRING_IGNORE_LISTAny other comments?
Thanks #DataUmbrellla