New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC minor fixes to examples for neighbors transformers #21057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from adding a small comment to point out that the cache is in a temporary directory, then everything looks fine.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the follow up PR @jalexand3r !
LGTM!
…21057) Co-authored-by: Johnathan Alexander <jalexander86@gatech.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Johnathan Alexander <jalexander86@gatech.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…21057) Co-authored-by: Johnathan Alexander <jalexander86@gatech.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Reference Issues/PRs
Follow-up to discussion in #21011 (already closed)
What does this implement/fix? Explain your changes.
Minor doc fixes to add fit and transform/predict to different neighbors transformer examples:
KNeighborsTransformer
example has pipeline removed to highlight shape of resulting distance matrix/graphKNeighborsTransformer
pipeline toIsomap
is left in general neighbors documentation but now includesfit_transform
and replaces fake directory'/path/to/cache'
that caused tests to failRadiusNeighborsTransformer
pipeline now includesfit_predict
Any other comments?
None