Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC minor fixes to examples for neighbors transformers #21057

Merged
merged 4 commits into from Sep 18, 2021

Conversation

jalexand3r
Copy link
Contributor

@jalexand3r jalexand3r commented Sep 15, 2021

Reference Issues/PRs

Follow-up to discussion in #21011 (already closed)

What does this implement/fix? Explain your changes.

Minor doc fixes to add fit and transform/predict to different neighbors transformer examples:

  • KNeighborsTransformer example has pipeline removed to highlight shape of resulting distance matrix/graph
  • KNeighborsTransformer pipeline to Isomap is left in general neighbors documentation but now includes fit_transform and replaces fake directory'/path/to/cache' that caused tests to fail
  • RadiusNeighborsTransformer pipeline now includes fit_predict

Any other comments?

None

@jalexand3r jalexand3r reopened this Sep 15, 2021
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from adding a small comment to point out that the cache is in a temporary directory, then everything looks fine.

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow up PR @jalexand3r !

LGTM!

@thomasjpfan thomasjpfan merged commit 623026e into scikit-learn:main Sep 18, 2021
@jalexand3r jalexand3r deleted the doc-fixes branch September 18, 2021 17:27
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Sep 20, 2021
…21057)

Co-authored-by: Johnathan Alexander <jalexander86@gatech.edu>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
adrinjalali pushed a commit that referenced this pull request Sep 23, 2021
Co-authored-by: Johnathan Alexander <jalexander86@gatech.edu>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…21057)

Co-authored-by: Johnathan Alexander <jalexander86@gatech.edu>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants