MAINT Move DistanceMetric under metrics
#21177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Sep 28, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
11 tasks
jjerphan
commented
Oct 6, 2021
| #cython: cdivision=True | ||
| # cython: boundscheck=False | ||
| # cython: cdivision=True | ||
| # cython: initializedcheck=False |
There was a problem hiding this comment.
Note that checks settable via initializedcheck are activated by default.
I preferred to turned it off here: in practice, it does not change something but it might for new interfaces such as the ones introduced in #20254.
rth
reviewed
Oct 8, 2021
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…-learn#21248) * Remove SplineTransformer from DOCSTRING_IGNORE_LIST * Fix numpydocs from SplineTransformer
…cikit-learn#21277) * Remove SelfTrainingClassifier from DOCSTRING_IGNORE_LIST * Fix numpydocs from SelfTrainingClassifier * Change docstrings to maintain consistency
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
ogrisel
approved these changes
Oct 8, 2021
…ngly Co-authored-by: Roman Yurchak <rth.yurchak@pm.me> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Roman Yurchak <rth.yurchak@pm.me> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
jeremiedbb
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
2 approvals. I think all comments have been resolved.
LGTM for me as well. Let's merge. Thanks @jjerphan !
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Extracted from #20254.
What does this implement/fix? Explain your changes.
DistanceMetricwas introduced withneighbors.*Tree. However, it is being used in other algorithms.Also #20254 relies on
DistanceMetricfor its implementation inmetrics.This adds a deprecation cycle on this public interface.
For consistency, this moves
DistanceMetricundermetrics.Any other comments?
Type definitions have also been moved to
utilsare they are being moved in several modules.