-
-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Adds quicker CI failure to reduce resource usage #21497
Conversation
Could you please add a top level comment in this file to explain the logic behind this dependency graph? |
azure-pipelines.yml
Outdated
- template: build_tools/azure/posix.yml | ||
parameters: | ||
name: Linux | ||
vmImage: ubuntu-20.04 | ||
name: Ubuntu_Bionic_Parallel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of introducing this redundant build entry, we could just change the condition on the other builds to use a dis-junction such as:
or (
in(dependencies['Ubuntu_Bionic']['result'], 'Succeeded', 'Skipped'),
contains(dependencies['git_commit']['outputs']['commit.message'], '[azure all-parallel]')
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unable to get this to work without the redundant build. The other builds are configured with dependsOn: [git_commit, linting, Ubuntu_Bionic]
, which waits for Ubuntu_Bionic
to complete.
Edit: Scratch this last comment. On the latest run the bionic job was the fastest. |
7d7da46
to
f6c1bb3
Compare
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
After looking at this PR again, I reworked the comments in the yaml files to better explain what is going on. Here are the output of the CI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The comments are much simpler and clearer to me know. Thank you for making the CI usage less resources, @thomasjpfan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the improvement. Hopefully this will reduce our CI usage.
If this strategy proves to be annoying or too complex to understand, we can always revert.
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
…earn#21497)" This reverts commit e1ec3f9.
Reference Issues/PRs
Closes #21403
What does this implement/fix? Explain your changes.
This PR allows
Ubuntu_Bionic
to run first and have most of the other instances depend on it.I added a second
Ubuntu_Bionic_Parallel
that runs only when[azure all-parallel]
is in the commit message. If[azure all-parallel]
is not in the commit message, thenUbuntu_Bionic_Parallel
is skipped.Ubuntu_Bionic
only runs when[azure all-parallel]
is not in the commit message.The other instances are updated to run when
Ubuntu_Bionic
succeeds or skipped, which covers all the non-failure cases.