FIX Make DistanceMetrics support readonly buffers attributes #21694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jjerphan
changed the title
jeremiedbb
reviewed
Nov 17, 2021
Co-authored-by: Jérémie du Boisberranger <jeremiedb>
|
Failing CI jobs for documentation are being addressed by: #21698. |
ogrisel
approved these changes
Nov 18, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
ogrisel
reviewed
Nov 18, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
Good to see that |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 22, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
mathijs02
pushed a commit
to mathijs02/scikit-learn
that referenced
this pull request
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Relates to #21685.
What does this implement/fix? Explain your changes.
03aa496#diff-8440f74258fda86e966d2b78a62c660ece7c2385ac7a55d0e40d552a492192c3R54-R55 converted the
vecandmatndarray into not const qualified memory views.Hence, when creating
DistanceMetricinstances (e.g. when unpickling them) an error is raised when numpy array buffer are readonly, (which is a common case in framework for distributed computating).Any other comments?
This fix is currently WIP.
An alternative fix would be to keep the introduced test but revert 03aa496.