DOC convert to notebook style SVM C scaling example #21776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@thomasjpfan @lesteve it should not be a controversial DOC merge. |
thomasjpfan
reviewed
May 5, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…xample_improve_svm_c
thomasjpfan
approved these changes
Nov 28, 2022
thomasjpfan
added
the
Waiting for Second Reviewer
|
Since this PR is hanging for one year out there and it only changes the style, I will merge it upon a single approval, as we do for trivial documentation changes. Thanks @thomasjpfan |
|
I was just making a review at the moment :') |
|
@ArturoAmorQ do not hesitate to open a new PR if you have further improvements. |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up after reviewing an example that was speeding up the notebook.
I just modify the example to be more notebook-style since we already had some sections in the summary docstring. Now, this is better in included.
In addition, I used the
validation_curveinstead of the grid-search since we don't have that many examples and this is a perfect analysis to use it. I also usedpandasto make the plotting a little bit more intuitive. In general, we have many fewer indentation levels now.