Fix lars #218
Merged
Fix lars #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| implemented in scikit-learn using the :class:`Fast ICA <FastICA>` | ||
| algorithm. | ||
|
|
||
| It is classically used to separate mixed signals (a problem know as |
Found it by comparing with R. How do you test for something like this?
This reverts commit c3ba6bb.
|
Note : I haven't run the tests, my system exploded yesterday. Otherwise it can be merged with @agramfort's blessing. |
|
I have failing doctests. They might be harmless, as they were previously computed values using the buggy implementation, but I'll wait for @agramfort to confirm that before fixing the failures and merging. |
|
Fixed the doctest |
|
shall I merge? |
|
yes if you are OK with me reverting your patches :-) |
|
pick the commits you want. On Tue, Jul 19, 2011 at 12:35 PM, fabianp
|
fabianp
pushed a commit
that referenced
this pull request
Jul 19, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gael's patch and my test -- for discussion, there are still missing bits.