New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Updated documentation to show jaccard score usage for image comparison #21978
DOC Updated documentation to show jaccard score usage for image comparison #21978
Conversation
Thanks @JakeCowton for your pull request.
Do you mind fixing it? Green checks will bring more attention to your work. Thanks. |
Docs now show 2D jaccard score usage for image comparison
e6501ef
to
74e4877
Compare
@cmarmo I've corrected the necessary components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have any objection to this addition, but let's wait for a core-dev review.
Thanks for your contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sensible to me. Thank you, @JakeCowton!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @JakeCowton !
@thomasjpfan thanks, I've integrated those changes. |
…rison (scikit-learn#21978) * FIX Updated jaccard score documentation Docs now show 2D jaccard score usage for image comparison * Updated jaccard_score docs to use micro avg in 2d comparison
What does this implement/fix? Explain your changes.
Fixes #21977
Any other comments?
I'm not sure what the use case is for having the docs show the way to calculate the Jaccard score for the first row of a matrix, but given how long those docs have been around I'm hesitant to assume they're wrong. Instead I've added lines to show how to calculate the Jaccard score for 2D input, often used for comparing binary images.