DOC Point GradientBoosting towards HistGradientBoosting #23340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
May 12, 2022
added 2 commits
May 12, 2022 18:16
lesteve
reviewed
May 18, 2022
ogrisel
approved these changes
May 23, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jjerphan
reviewed
May 24, 2022
There was a problem hiding this comment.
Thank you for cross-referencing the HGBT interfaces, @ArturoAmorQ.
I think the terminology can be made a bit more precise, for instance by replacing "estimator" by "algorithm". Here are a few comments in this regard.
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
…nto GBDT_to_HGBDT
jjerphan
approved these changes
May 24, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…#23340) * Point GradientBoosting towards HistGradientBoosting on docstrings * Point GradientBoosting towards HistGradientBoosting on examples * Avoid the GB acronym * Iter * Apply suggestion from lesteve * Apply suggestions from code review Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Format * Apply suggestions from code review Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> * Format Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Point GradientBoosting towards HistGradientBoosting on docstrings * Point GradientBoosting towards HistGradientBoosting on examples * Avoid the GB acronym * Iter * Apply suggestion from lesteve * Apply suggestions from code review Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Format * Apply suggestions from code review Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> * Format Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
mathijs02
pushed a commit
to mathijs02/scikit-learn
that referenced
this pull request
Dec 27, 2022
…#23340) * Point GradientBoosting towards HistGradientBoosting on docstrings * Point GradientBoosting towards HistGradientBoosting on examples * Avoid the GB acronym * Iter * Apply suggestion from lesteve * Apply suggestions from code review Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Format * Apply suggestions from code review Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> * Format Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #23231.
What does this implement/fix? Explain your changes.
People may use
GradientBoosting*in cases whereHistGradientBoosting*would perform better.This PR addresses the problem by adding references towards the Hist versions in the docstrings and examples.
Any other comments?
This is a quick fix as suggested by this comment.
Reworking the examples (as mentioned in this comment) or adding an additional example (as mentioned here) is left for another PR.