TST Add common tests for single class fitting induced by sample weights #24140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmarmo
added
module:test-suite
|
I am using precommit and |
glemaitre
changed the title
glemaitre
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Given the +1 or @jnothman on the original PR, my approval, and @thomasjpfan review, I think that this PR is good to be merged.
| @@ -3167,7 +3167,7 @@ const char *PREFIX(check_parameter)(const PREFIX(problem) *prob, const svm_param | |||
| free(newprob.x); | |||
| free(newprob.y); | |||
| free(newprob.W); | |||
| return "Invalid input - all samples with positive weights have the same label."; | |||
| return "Invalid input - all samples with positive weights belong to the same class."; | |||
There was a problem hiding this comment.
For other reviewers: This is the only change in the file. I know that we usually don't do cosmetic change but here we remove all trailingspace once for all. I don't want to revert them.
glemaitre
changed the title
|
Going to merge when the CIs turn green |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 3, 2023
…ts (scikit-learn#24140) Co-authored-by: johayon <johayon.math@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…ts (scikit-learn#24140) Co-authored-by: johayon <johayon.math@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…ts (scikit-learn#24140) Co-authored-by: johayon <johayon.math@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
…ts (scikit-learn#24140) Co-authored-by: johayon <johayon.math@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
…ts (#24140) Co-authored-by: johayon <johayon.math@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10337.
Supersedes and closes #10347.
What does this implement/fix? Explain your changes.
This pull request adds common tests for classifiers reducing to less than two classes via sample weights during fit.
See this comment in #10337
Any other comments?
In the meanwhile SVM was modified by #14286.
The error message has been updated to make the new common tests pass.
#10347 already received one approval by @jnothman.