MAINT Clean deprecation for 1.2: learning_rate and init in TSNE #24389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
added
No Changelog Needed
Quick Review
|
I'm not sure about codecov here. It complains that a branch with init="random" is not covered but there's at least 1 test that sets init="random". |
|
Yep, I don't understand codecov. There are several tests with |
|
Merging since we have 2 approvals and that I don't trust codecov after checking the tests. |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
…it-learn#24389) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the ending deprecation for
learning_rateandinitby:versionchangedfilterwarningsin the tests.