Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN accept l2 metric with ward linkage in agglomeration clustering #24681

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

glemaitre
Copy link
Member

closes #18531

We should be able to use the combination metric="l2" and linkage="ward".
It is equivalent to metric="euclidean".

@ogrisel
Copy link
Member

ogrisel commented Oct 17, 2022

Are we sure we want to introduce aliases like this. We did recently the opposite for loss/objective functions were we deprecated synonyms.

@glemaitre
Copy link
Member Author

Deprecating "l2" or making it an alias for "euclidean" would be fine with me.

The deprecation of "l2" would require more work to be consistent across scikit-learn.
I would expect to start deprecating wherever we have both "euclidean" and "l2" possibilities (e.g. pairwise distances, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ward linkage ValueError with l2 affinity (Agglomerative Clustering)
2 participants