FIX acc_find_split_time and acc_compute_hist_time of root nodes in HistGradientBoosting* #24894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we mention this in the changelog? |
|
Yes, an entry in the changelog should be good indeed. People will get an increase in time and could think that it comes from a bug in the code but this is not the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
HistGradientBoostingClassifierandHistGradientBoostingRegressor, withverbose>=1, print detailed timing information on computing histograms and finding best splits. The current implementation neglects the computations ofacc_find_split_timeas well asacc_compute_hist_timefor the root nodes.What does this implement/fix? Explain your changes.
Add additional time spent in root nodes.