Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Fix FutureWarning in decomposition/plot_faces_decomposition.html #24936

Conversation

jpangas
Copy link
Contributor

@jpangas jpangas commented Nov 15, 2022

Reference Issues/PRs

Fix towards #24876

What does this implement/fix? Explain your changes.

This fixes the FutureWarning show in decomposition/plot_faces_decomposition.html
The default value of n_init will change from 3 to 'auto' in 1.4. Set the value of n_init explicitly to suppress the warning

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results changed slightly because we run only a single iteration but it does change the spirit of the example. This is good to be merged. Thanks @JohnPCode

@glemaitre glemaitre merged commit 3d16a21 into scikit-learn:main Nov 15, 2022
@jpangas jpangas deleted the doc-Fix-FutureWarning-in-decomposition/plot_faces_decomposition.html branch November 15, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants