-
-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Improve docs of BaseLabelPropagation.transduction_ #24985
Conversation
@@ -105,6 +105,34 @@ class BaseLabelPropagation(ClassifierMixin, BaseEstimator, metaclass=ABCMeta): | |||
``None`` means 1 unless in a :obj:`joblib.parallel_backend` context. | |||
``-1`` means using all processors. See :term:`Glossary <n_jobs>` | |||
for more details. | |||
|
|||
Attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the convention is -> unsure if the extra docs on BaseLabelPropagation
make sense as users can't directly import/access this class.
Does someone know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traditionally, we only include Attribute docs for public classes. For example, BaseDecisionTree
does not include any docs for Attributes because it is private:
scikit-learn/sklearn/tree/_classes.py
Line 90 in 75db1bc
class BaseDecisionTree(MultiOutputMixin, BaseEstimator, metaclass=ABCMeta): |
In this case, since BaseLabelPropagation
is a private class, I would not include the Attributes section here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the question to an experienced maintainer this looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
@@ -105,6 +105,34 @@ class BaseLabelPropagation(ClassifierMixin, BaseEstimator, metaclass=ABCMeta): | |||
``None`` means 1 unless in a :obj:`joblib.parallel_backend` context. | |||
``-1`` means using all processors. See :term:`Glossary <n_jobs>` | |||
for more details. | |||
|
|||
Attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traditionally, we only include Attribute docs for public classes. For example, BaseDecisionTree
does not include any docs for Attributes because it is private:
scikit-learn/sklearn/tree/_classes.py
Line 90 in 75db1bc
class BaseDecisionTree(MultiOutputMixin, BaseEstimator, metaclass=ABCMeta): |
In this case, since BaseLabelPropagation
is a private class, I would not include the Attributes section here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM. Thanks @scottgigante-immunai |
The relationship between
fit
andtransduction_
is not super clear. This PR improves the documentation around that. Closes #24898.