Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Replace broken link for pymc #25027

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

Da-Lan
Copy link
Contributor

@Da-Lan Da-Lan commented Nov 24, 2022

Thank you for maintaining scikit-learn !

This is a fix related to the issue #25024

Have a great day

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @Da-Lan

@@ -285,7 +285,7 @@ Other packages useful for data analysis and machine learning.
statistical models. More focused on statistical tests and less on prediction
than scikit-learn.

- `PyMC <https://pymc-devs.github.io/pymc/>`_ Bayesian statistical models and
- `PyMC <https://github.com/pymc-devs/pymc>`_ Bayesian statistical models and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should point to the docs as before: https://www.pymc.io/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adrinjalali, I applied your suggestion.

@thomasjpfan thomasjpfan changed the title fix: replace broken link for pymc DOC Replace broken link for pymc Nov 25, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinjalali adrinjalali merged commit fa31fff into scikit-learn:main Nov 28, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 21, 2022
glemaitre pushed a commit that referenced this pull request Dec 21, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants