DOC fix link to devguide triaging guide #25035
Conversation
doc/conf.py
Outdated
| @@ -630,6 +630,7 @@ def setup(app): | |||
| "https://microsoft.com/", | |||
| "https://www.jstor.org/stable/2984099", | |||
| "https://stat.uw.edu/sites/default/files/files/reports/2000/tr371.pdf", | |||
| "https://devguide.python.org/triage/triaging/index.html#becoming-a-member-of-the-python-triage-team", | |||
There was a problem hiding this comment.
the link works because there's a redirect. We should fix the docs to put the new link, which would be: https://devguide.python.org/triage/triaging/index.html
There was a problem hiding this comment.
I think the issue here is actually the anchor #becoming-a-member-of-the-python-triage-team I have updated the issue with more info about each "broken" link.
There was a problem hiding this comment.
Thanks, will do now. I found that was the case with the Google Open source link. My commit for that particular link will be to the corresponding .rst (about.rst)
There was a problem hiding this comment.
Not sure what to do here and which section it was pointing to and what we wanted to say with this link.
I agree with @adrinjalali that we should try to find an appropriate link in this case rather than add it to the ignore list.
doc/governance.rst
Outdated
| @@ -36,7 +36,7 @@ crucial to improve the communication in the project and limit the crowding | |||
| of the issue tracker. | |||
|
|
|||
| Similarly to what has been decided in the `python project | |||
| <https://devguide.python.org/triaging/#becoming-a-member-of-the-python-triage-team>`_, | |||
| <https://devguide.python.org/triage/triaging/index.html>`_, | |||
There was a problem hiding this comment.
this sounds good to me, but the conf.py change then need to be reverted :)
There was a problem hiding this comment.
Actually I think this may be the link we want (the anchor does still exist but in a different page somehow): https://devguide.python.org/triage/triage-team/#becoming-a-member-of-the-python-triage-team
There was a problem hiding this comment.
Missed in error. Working on that now.
There was a problem hiding this comment.
I removed the Devguide link from conf.py. I'll go back in and update the governance.rst link to the one you provided @lesteve
There was a problem hiding this comment.
@jasonjg you might have missed this comment: #25035 (comment)
There was a problem hiding this comment.
https://devguide.python.org/triage/triage-team/#becoming-a-member-of-the-python-triage-team
Just checking before I make a commit. @lesteve Is the URL I quoted the one you want to use?
There was a problem hiding this comment.
Yes please 🙏.
I think this was the original intent of the link to point towards the Python Triage team policy (rather than instructions on how to triage an issue)
|
Merging, thanks a lot! |
|
Thank you both for your assistance! |
Reference Issues/PRs
Towards #25024
What does this implement/fix? Explain your changes.
The link is working in a browser. Added the link to linkcheck_ignore.
Any other comments?