Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken link for minka- logreg #25039

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Conversation

shrankhla20
Copy link
Contributor

#25024 issue

Reference Issues/PRs

What does this implement/fix? Explain your changes.

removed slash after the pdf link and it started working

Any other comments?

Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

For completeness sake, this link was flagged as broken by make linkcheck but the link on the documentation is fine.

Edit: actually the link was broken in the doc https://scikit-learn.org/dev/modules/linear_model.html#logistic-regression. I was looking at the wrong page.

Fixed broken link for multiclass spectral clustering yu-shi reference 
scikit-learn#25024 issue
@lesteve
Copy link
Member

lesteve commented Nov 25, 2022

@shrankhla20 you just pushed a commit fixing another link, can you open a separate PR for it?

One PR per link makes it easier to track the advancement of the issue 🙏

@lesteve lesteve merged commit 5599dcd into scikit-learn:main Nov 25, 2022
@lesteve
Copy link
Member

lesteve commented Nov 25, 2022

@shrankhla20 I reverted your last commit and merged your PR, thanks a lot!

Feel free to open a separate PR for the other link you were working on.

Here is your diff in case it helps:

commit 61be65ad83f8073edb70e10c19ea308af297dd5a (HEAD -> shrankhla)
Author: Shrankhla Srivastava <shrankhla.srivastava@gmail.com>
Date:   Fri Nov 25 16:28:43 2022 +0530

    Fixes broken link for yu-shi msc
    
    Fixed broken link for multiclass spectral clustering yu-shi reference
    #25024 issue

diff --git a/doc/modules/clustering.rst b/doc/modules/clustering.rst
index 40ca15aaa..5ca3a6f46 100644
--- a/doc/modules/clustering.rst
+++ b/doc/modules/clustering.rst
@@ -532,7 +532,7 @@ below.
 .. topic:: References:
 
  * `"Multiclass spectral clustering"
-   <https://www1.icsi.berkeley.edu/~stellayu/publication/doc/2003kwayICCV.pdf>`_
+   <https://people.eecs.berkeley.edu/~jordan/courses/281B-spring04/readings/yu-shi.pdf>`_
    Stella X. Yu, Jianbo Shi, 2003
 
  * :doi:`"Simple, direct, and efficient multi-way spectral clustering"<10.1093/imaiai/iay008>`

@shrankhla20
Copy link
Contributor Author

@lesteve Thank you so much.

P.s. This marks my first contribution to open source !

@lesteve
Copy link
Member

lesteve commented Nov 25, 2022

Great stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants