Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC consistency fixes in multiclass estimators docstring #25226

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

glemaitre
Copy link
Member

Fixes:

  • missing backticks for term
  • using {array-like, sparse matrix} for consistency with other estimators
  • make the See Also sections consistent

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

sklearn/multiclass.py Outdated Show resolved Hide resolved
Input data.

Returns
-------
T : (sparse) array-like of shape (n_samples, n_classes)
T : {array-like, sparse matrix} of shape (n_samples, n_classes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think the output of this method can be sparse.

sklearn/multiclass.py Outdated Show resolved Hide resolved
sklearn/multiclass.py Outdated Show resolved Hide resolved
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan enabled auto-merge (squash) December 22, 2022 16:42
@thomasjpfan thomasjpfan merged commit c78a422 into scikit-learn:main Dec 22, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 3, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants