FIX expose fill_value in IterativeImputer #25232
Merged
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
changed the title
fill_value in IterativeImputer
glemaitre
changed the title
fill_value in IterativeImputer
glemaitre
reviewed
Dec 26, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
@glemaitre Thanks for the feedback. Have your concerns been sufficiently addressed? |
glemaitre
reviewed
Jan 9, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
betatim
reviewed
Jan 9, 2023
Co-authored-by: Tim Head <betatim@gmail.com>
thijs-vanweezel
commented
Jan 9, 2023
|
@glemaitre, do you have any idea why these tests are failing? I ran pytest and flake8, and neither reported an issue. |
|
I would assume that we need to merge |
glemaitre
approved these changes
Jan 14, 2023
glemaitre
added
the
Waiting for Second Reviewer
TomDLT
approved these changes
Jan 17, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Tim Head <betatim@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Tim Head <betatim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #25052
What does this implement/fix? Explain your changes.
Adds the parameter
fill_valuetoIterativeImputer.Any other comments?
@betatim suggested adding support for passing any imputer as
initial_strategy. However, I purposefully dismissed this, for the following two reasons:add_indicatortoTruein an imputer passed asinitial_strategy,IterativeImputerwould probably run into issues.IterativeImputercould be described as a general imputer, i.e., one that is able to leverage any regressor or classifier for imputation purposes, and thereby making other imputers redundant.Lastly, additional to the delay resulting from my exams, this was my first time contributing to open source (and in the process, I crashed my PC). Therefore, I am interested to see whether my work meets the sklearn standard.
Cheers.