Sgd rename #26
Sgd rename #26
Conversation
pprett
commented
Dec 2, 2010
pprett
commented
- Moved sgd examples to examples/linear_model
- Prefixed examples with sgd
- Moved covertype example to benchmarks
- Updated documentation (linear_model.rst, classes.rst)
renamed ClassifierSGD to SGDClassifier (same for Regressor) updated setup.py files updated examples updated docs
Merge stochastic_descent into linear_model.
minor fixes in some examples. updated sgd.rst
….rst). COSMIT in stochastic_gradient.py docstring.
|
The overall look and feel looks fine to me: +1 for the merge if the test pass and the documentation build with the auto-examples on. |
|
Thanks for this. There are some errors in the import paths of the examples when you import "from scikits.learn.linear_model.stochastic_gradient.sparse" , it should be from "scikits.learn.linear_model.sparse" . As a suggestion, some other paths can be shortened (which I think its good on examples) : the stochastic_gradient in "from scikits.learn.linear_model.stochastic_gradient import SGDClassifier" is superfluous. +1 for the merge once the import paths have been fixed. |
COSMIT import paths in plot examples. Rephrased SGD outline in linear_model.rst
|
thanks for reminding me... I completely forgot to run the non-auto examples. I've now fixed the import paths both in the auto and non-auto examples -> I'll push the changes to master. thanks, |
|
Great, thanks. No excuse for me to not do my part now :-) |
Fix pprett comments
