Add mps device in Array API tests
#27098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
reviewed
Aug 18, 2023
betatim
approved these changes
Aug 18, 2023
betatim
reviewed
Aug 18, 2023
betatim
reviewed
Aug 18, 2023
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PR part of the Sprint at EuroSciPy 2023)
While trying to contribute to the #22352 effort, I have realised that the
mpsdevice (the GPU device name in PyTorch for Mac with M1/M2) was not part of the Array API tests. I added this here.Thanks to @ogrisel for the help with this :)