ENH Add Array API compatibility to MaxAbsScaler #27110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add somewhere in the docs that sparse arrays are not supported by the Array API? |
As far as I know, no library implementing the Array API specification implement sparse memory layouts. But in theory, nothing prevents someone to write such a library as far as I know. If that would be the case, there should not be anything to change at the scikit-learn level. |
|
BTW, I tested with the PyTorch / MPS backend on my laptop and this PR tests pass. |
betatim
reviewed
Aug 22, 2023
|
Thanks a lot! |
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 29, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
It makes the
MaxAbsScalerimplementation compatible with the Array API.Any other comments?
I had to make a small adjustment to
_nanmaxand_nanmin, becausempscomplained that those+/-infarrays were not on the same (mps) device.