TST Extend tests for scipy.sparse.*array in sklearn/tests/test_kernel_approximation.py
#27301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohitslohit
changed the title
OmarManzoor
changed the title
scipy.sparse/*array in sklearn\tests\test_kernel_approximation.py and sklearn/utils/_testing.py
OmarManzoor
changed the title
scipy.sparse/*array in sklearn\tests\test_kernel_approximation.py and sklearn/utils/_testing.pyscipy.sparse.*array in sklearn/tests/test_kernel_approximation.py and sklearn/utils/_testing.py
OmarManzoor
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Thanks for the PR @lohitslohit. Is there a specific reason why we are including two files in the same PR?
|
@OmarManzoor No specific reason. I am new to open source. |
|
@lohitslohit In that case I think it would be suitable to treat each file in a separate PR as that is the format that is being followed with this meta issue. |
…sting.py" due to the duplicate file entry This reverts commit 3fc0fc4.
…to test-kernel-ap
lohitslohit
changed the title
scipy.sparse.*array in sklearn/tests/test_kernel_approximation.py and sklearn/utils/_testing.pyscipy.sparse.*array in sklearn/tests/test_kernel_approximation.py
|
Hi, Isn't this a duplicate of #27275? |
|
OK so I am closing it in preference of this PR. |
OmarManzoor
reviewed
Sep 11, 2023
glemaitre
approved these changes
Sep 11, 2023
OmarManzoor
approved these changes
Sep 12, 2023
OmarManzoor
reviewed
Sep 12, 2023
|
@glemaitre I think the only tests that are failing are related to docs with the scipy-dev CI. CI pipeline link |
|
Indeed. The docstring failure will be always visible. Feel free to merge when it comes to this issue. |
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…nel_approximation.py` (scikit-learn#27301) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #27090.