Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Add Array API compatibility to Normalizer #27558

Merged
merged 11 commits into from Nov 14, 2023
Merged

ENH Add Array API compatibility to Normalizer #27558

merged 11 commits into from Nov 14, 2023

Conversation

EdAbati
Copy link
Contributor

@EdAbati EdAbati commented Oct 10, 2023

Reference Issues/PRs

Towards #26024

What does this implement/fix? Explain your changes.

It makes the Normalizer implementation compatible and tested with the Array API.

@github-actions
Copy link

github-actions bot commented Oct 10, 2023 •
edited

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5eef1e2. Link to the linter CI: here

betatim
betatim reviewed Oct 20, 2023
View reviewed changes
doc/whats_new/v1.4.rst Outdated Show resolved Hide resolved
betatim
betatim reviewed Oct 20, 2023
View reviewed changes
sklearn/utils/extmath.py Outdated Show resolved Hide resolved
betatim
betatim reviewed Oct 20, 2023
View reviewed changes
sklearn/utils/extmath.py Outdated Show resolved Hide resolved
@betatim betatim mentioned this pull request Oct 24, 2023
Open
@betatim
Copy link
Member

betatim commented Oct 24, 2023

@EdAbati looks like the test failures are real test failures related to the PR 🎉

betatim
betatim approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ogrisel
ogrisel approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks for the PR!

@ogrisel ogrisel merged commit 5cf61b2 into scikit-learn:main Nov 14, 2023
27 checks passed
@EdAbati EdAbati deleted the normalizer-array-api branch November 14, 2023 13:09
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@EdAbati @REDVM
ENH Add Array API compatibility to Normalizer (scikit-learn#27558)
3ff8a2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@betatim betatim betatim approved these changes

Assignees
No one assigned
Labels
Array API module:preprocessing module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EdAbati @betatim @ogrisel