FIX RandomForestRegressor OOB fails with integer-values multiple targets - #27817
Merged
Conversation
danieleongari
changed the title
danieleongari
force-pushed
the
fix/issue_27814
branch
from
November 21, 2023 16:35
d9dd142 to
c166adf
Compare
danieleongari
force-pushed
the
fix/issue_27814
branch
from
November 21, 2023 16:36
c166adf to
ae4aa5a
Compare
glemaitre
reviewed
Nov 22, 2023
glemaitre
reviewed
Nov 22, 2023
glemaitre
reviewed
Nov 22, 2023
glemaitre
changed the title
Member
|
The failure reported was only some failure related to codecov failing to upload the coverage report. |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Contributor
Author
|
Thanks @glemaitre for the fast review: I addressed all your concerns. |
glemaitre
self-requested a review
November 23, 2023 09:40
glemaitre
reviewed
Nov 23, 2023
glemaitre
left a comment
glemaitre
left a comment
Member
There was a problem hiding this comment.
A couple of comments to improve the tests.
Contributor
Author
|
Hi @glemaitre, |
glemaitre
reviewed
Nov 24, 2023
glemaitre
reviewed
Nov 24, 2023
glemaitre
reviewed
Nov 24, 2023
glemaitre
reviewed
Nov 24, 2023
glemaitre
approved these changes
Nov 24, 2023
glemaitre
left a comment
glemaitre
left a comment
Member
There was a problem hiding this comment.
Just small changes for following the convention naming that we usually use. Otherwise, LGTM. Thanks @danieleongari
Adding a label to request a second review.
glemaitre
added
the
Waiting for Second Reviewer
Contributor
Author
|
All suggestions by @glemaitre implemented in the last commit, thanks! |
thomasjpfan
reviewed
Nov 24, 2023
thomasjpfan
left a comment
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR @danieleongari !
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Contributor
Author
|
thanks @glemaitre @thomasjpfan. All comments have been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27814
Allow to compute the OOB score with
RandomForestRegressorand an integral multi-target regression.