Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX raise NotFittedError in OrdinalEncoder when required #27821

Merged
merged 2 commits into from Nov 23, 2023
Merged

FIX raise NotFittedError in OrdinalEncoder when required #27821

merged 2 commits into from Nov 23, 2023

Conversation

glemaitre
Copy link
Member

@ogrisel observed this error while answering some question on the forum of the scikit-learn MOOC.

Since this estimator was never stateless, we can safely considered it as a bug fix.

@glemaitre
Copy link
Member Author

ping @ogrisel

ogrisel
ogrisel reviewed Nov 21, 2023
View reviewed changes
doc/whats_new/v1.4.rst Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 32065c3. Link to the linter CI: here

ogrisel
ogrisel approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would probably a common a test for this but let's quickly fix this bug first.

thomasjpfan
thomasjpfan approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 0816e00 into scikit-learn:main Nov 23, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glemaitre @ogrisel @thomasjpfan