New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT remove deprecated parameters in MiniBatchDictionaryLearning #27834
MAINT remove deprecated parameters in MiniBatchDictionaryLearning #27834
Conversation
# XXX callback param added for backward compat in #18975 but a common | ||
# unified callback API should be preferred | ||
if self.callback is not None: | ||
self.callback(locals()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably not covered in the past as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove all parameters that have been deprecated in the
MiniBatchDictionaryLearning
and announced during a deprecation cycle.