add feature_names_in_ and n_features_in_ attributes to dummy estimators #27937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR fails on a single test because the error type is now different ( def test_quantile_strategy_empty_train():
est = DummyRegressor(strategy="quantile", quantile=0.4)
with pytest.raises(ValueError):
est.fit([], [])Not sure if I can just change the error type in the test because I am unsure what the test is actually testing (that it fails or that a specific error is raised). |
|
I think it'd make sense to fix the test, the behavior is now more consistent with the other estimators. It would need a changelog entry though. |
|
@yuanx749 can you review again? |
I just came across this PR and think it is good. But I am not a maintainer, so you need to ask a maintainer to approve. Sorry for the confusion... |
|
I see. @adrinjalali can you review? |
adrinjalali
reviewed
Jan 3, 2024
|
@adrinjalali can this be merged? |
thomasjpfan
approved these changes
Jan 17, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #27907
What does this implement/fix? Explain your changes.
Add the attributes
feature_names_in_andn_features_in_to the Dummy estimators.