FIX correct NeighborhoodComponentsAnalysis (NCA) _n_features_out value
#28306
+31
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glemaitre friendly ping here: is this fix still needed? |
|
I have to make a deeper review but we need to add a new non-regression test to reproduce the failure seen in the issue and make sure that the changes are fixing it. We also need to add an entry in the changelog under the 1.4.2 version. I'll add the milestone. |
glemaitre
reviewed
Feb 19, 2024
There was a problem hiding this comment.
So you can add this entry in the 1.4.2 changelog:
:mod:`sklearn.neighbors`
........................
- |Fix| Fixes :class:`neighbors.NeighborhoodComponentsAnalysis` such that
`get_feature_names_out` returns the correct number of feature names.
:pr:`28306` by :user:`Brendan Lu <brendanlu>`.
jeremiedbb
added
the
To backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #28293
What does this implement/fix? Explain your changes.
Implements the changes as suggested by @johentsch, similar to the base pca class.
Any other comments?
Adjusted the (faulty?) existing test logic to pick this issue up.