CI Use same install script for Windows as the other builds #28500
Conversation
| # Build scikit-learn | ||
| python setup.py bdist_wheel | ||
|
|
||
| # Install the generated wheel package to test it | ||
| pip install --pre --no-index --find-links dist scikit-learn |
There was a problem hiding this comment.
Using install.sh now results in installing sklearn via python setup.py develop but I guess it's fine. Would it be possible to enable meson instead ?
There was a problem hiding this comment.
I think this is fine too. I am not sure why Windows was different to be honest, maybe an historical thing where we were using a batch file before switching to bash?
It will be possible to use Meson if we want. Some testing in #28040 indicated that it was working fine on Windows.
Eventually, I have some plans to switch to Meson for all builds but one to keep testing building with setuptools.
There was a problem hiding this comment.
maybe an historical thing where we were using a batch file before switching to bash?
Yup, this is why there is a separate file in windows.
| # Build scikit-learn | ||
| python setup.py bdist_wheel | ||
|
|
||
| # Install the generated wheel package to test it | ||
| pip install --pre --no-index --find-links dist scikit-learn |
There was a problem hiding this comment.
maybe an historical thing where we were using a batch file before switching to bash?
Yup, this is why there is a separate file in windows.
After a few iterations, it seems like Windows CI is happy.