CI Use shared tool to upload nightly build wheels #28560
Conversation
.github/workflows/wheels.yml
Outdated
| uses: scientific-python/upload-nightly-action@b67d7fcc0396e1128a474d1ab2b48aa94680f9fc # 0.5.0 | ||
| with: | ||
| artifacts_path: dist/artifact | ||
| anaconda_nightly_upload_token: ${{ secrets.SCIKIT_LEARN_NIGHTLY_UPLOAD_TOKEN }} |
There was a problem hiding this comment.
This GitHub action only uploads scikit-learn nightly builds to the scientific-python-nightly-wheels channel.
However our existing build_tools/github/upload_anaconda.sh script also handles the staging of wheels generated from a stable release branch as part of our release automation workflow for pypi uploads.
Is there a way to configure the github action to also handle staging to a project specific channel?
Otherwise we would need a condition to either use our existing (simplified) script for staging and the shared github action for nightly builds.
There was a problem hiding this comment.
I saw that the script also handles wheels staging, that's why I did not remove it from the workflow. I will work on staging github action
There was a problem hiding this comment.
that's why I did not remove it from the workflow.
I don't understand this sentence: this PR (#28560) deletes the line 248 so the script build_tools/github/upload_anaconda.sh is no longer called for build staging, right?
We cannot merge the PR as is. Otherwise the release process is no longer automated.
There was a problem hiding this comment.
I am working on the build staging part, in the incoming commits this script can be deleted. Perhaps I convert this PR to draft to avoid any confusion.
| ARTIFACTS_PATH: dist/artifact | ||
| # Force a replacement if the remote file already exists | ||
| run: bash build_tools/github/upload_anaconda.sh | ||
| uses: scientific-python/upload-nightly-action@b67d7fcc0396e1128a474d1ab2b48aa94680f9fc # 0.5.0 |
There was a problem hiding this comment.
Is the use of a hash + version number comment an artifact of the use of dependabot to avoid having silent tag renaming not being reflected in our version control?
There was a problem hiding this comment.
It's not an artifact of dependabot usage.
- Here the hash, i.e., full length commit SHA signifies a secure way to use action provided by scientific-python.
#0.5.0is the current release of upload-nightly-action. This hash is manually updated for each release, for example by this PR. More information about the full commit length commit SHA can be found here. - Dependabot is used to automatically update non-default actions for a specified interval, here is weekly. More details about this tool can be found here.
There was a problem hiding this comment.
Thanks for the clarification. Maybe we could enable dependabot for github actions in a dedicated PR. I have no experience with using dependabot for that purpose I would appreciate what other maintainers about this change.
There was a problem hiding this comment.
Okay I will let the dependabot change for another PR
Reference Issues/PRs
Closes #24312
What does this implement/fix? Explain your changes.
Use scientific-python shared tool to upload nightly build wheels
Any other comments?
To be tested