BLD Avoid misleading OpenMP warning with Apple Clang #28839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Apr 15, 2024
jeremiedbb
reviewed
Apr 16, 2024
jeremiedbb
reviewed
Apr 16, 2024
sklearn/meson.build
Outdated
Comment on lines
71
to
77
| ''' | ||
| import os | ||
|
|
||
| compiler_env_vars_to_check = ["CPPFLAGS", "CFLAGS", "CXXFLAGS"] | ||
|
|
||
| compiler_env_vars_with_openmp = [var for var in compiler_env_vars_to_check if "-fopenmp" in os.getenv(var, "")] | ||
| print(compiler_env_vars_with_openmp) |
There was a problem hiding this comment.
can you put this in a variable to make the run_command invoke more readable ?
adrinjalali
approved these changes
Apr 18, 2024
| var for var in compiler_env_vars_to_check if "-fopenmp" in os.getenv(var, "")] | ||
| print(compiler_env_vars_with_openmp) | ||
| '''], check: true).stdout().strip() | ||
| warn_about_missing_openmp = compiler_env_vars_with_openmp == '[]' |
There was a problem hiding this comment.
it would be more standard I guess if the process would return 1 on failure instead of checking program's output. But it doesn't really matter here I guess.
There was a problem hiding this comment.
Why not but at the same time, the process returning 1 could also be because there is a syntax error in the Python snippet, so you would need additional logic or a different exit code, which would complicate things a bit.
There was a problem hiding this comment.
although, you could return a non-1 value. But doesn't matter. Merged :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #28710.
For now Meson OpenMP detection can not be trusted on Apple Clang, so when compilers environment variables are set we assume everything is going to be fine and the warning can be less scary.
I tested it on a OSX VM, it seems to work fine. I will trigger a wheel build since the macOS wheels should show the milder warning.
Edit: it does build log