Replace PYODIDE_PACKAGE_ABI with PYODIDE #28880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Indeed, it seems to be the case since pyodide 0.17.0 (last release is 0.25.1 at the time of writing) according to:
https://pyodide.org/en/stable/project/changelog.html#id52
I pushed an empty commit to trigger the pyodide CI on this PR. Assuming it's green, LGTM.
/cc @lesteve
|
BTW, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Pyodide is planning to remove the
PYODIDE_PACKAGE_ABIenv variable. This variable has been deprecated for a very long time. This PR replaces all appearance ofPYODIDE_PACKAGE_ABIwithPYODIDEenv variable, which Pyodide now recommends when checking if the build is targeting Pyodide.