Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Revert PyPy lock file after threadpoolctl min version bump #28894

Merged
merged 1 commit into from Apr 29, 2024

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Apr 25, 2024

Fixes #28879

The lock files were updated In #28838 for the bump of threadpoolctl min version. I thought I triggered all CIs but I forgot PyPy nightly and believe it or not, this one fails. It's not due to threadpoolctl but to another dependency update, and tracked in #28869.

This PR reverts the lock file of PyPy to its state before #28838.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 528e9e8. Link to the linter CI: here

@jeremiedbb jeremiedbb changed the title CI Revert PyPy lock file after CI Revert PyPy lock file after threadpoolctl min version bump Apr 25, 2024
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and CI is happy again. The root problem is still there though, but this works for me as a short term workaround.

@ogrisel ogrisel merged commit f9cab76 into scikit-learn:main Apr 29, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ CI failed on Linux_Nightly_PyPy.pypy3 (last failure: Apr 29, 2024) ⚠️
2 participants