ENH Add missing base.is_clusterer() function#28936
Conversation
adrinjalali
left a comment
There was a problem hiding this comment.
Since this is not introducing clusterer as a new thing, and it already exists, I'm okay with it.
|
Needs a changelog introducing the new function. |
Thanks for the hint. Added to changelog... |
|
BTW: I added this new function to the changelog of version 1.5. |
|
Yes, the changelog would need to be moved. |
Was necessary to get the 1.6 changelog file
|
Moved the changelog entry from version 1.5 to 1.6. |
glemaitre
left a comment
There was a problem hiding this comment.
We should also add the function into the API reference in the file doc/modules/classes.rst under the function of the module sklearn.base.
To get the doc/api_reference.py file
|
Do we need the |
|
LGTM, I'm enabling auto-merge. Thanks @ChVeen! |
Reference Issues/PRs
Fixes #28960
What does this implement/fix? Explain your changes.
This PR proposes to add the missing
base.is_clusterer()function analogously tobase.is_classifier().There is a user demand for this as can be seen in discussion #28904.
The missing unit test for
base.is_regressor()is added as well.Any other comments?