-
-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC use pydata-sphinx-theme for the website #29038
Conversation
…into new_web_theme
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
…es (#28623) Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Did we remove the |
Yes, as suggested in #28379 (comment). I'm adding it back in #29037, which should be merged into |
I made the last changes and pushed a full rebuild. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All green. I quickly skimmed trough the generated web site and everything looks good. Thanks @Charlie-XIAO !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the work @Charlie-XIAO
Will we get this theme for the 1.5 website (aka the one people will see under It would be nice to get it out, but given how little time there is between now and the release of 1.5 it might be smart to use the old theme for 1.5 and have this on the |
Basically, I would not delay and have the theme for 1.5. We had iteration in the branch |
Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Thank you for this work, @Charlie-XIAO! 💯 |
This work is done mostly by @Charlie-XIAO , this is a PR to merge the work into the main branch.