Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Make tests faster to run #3403

Merged
merged 5 commits into from Jul 17, 2014
Merged

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jul 16, 2014

Ongoing fix for #3402.

@ogrisel
Copy link
Member Author

ogrisel commented Jul 17, 2014

I think this set of fixes / optim can be merged as such. There is still room for improvement. In particular we should profile tests times and group them by module / package to get a better picture of what are the slowest modules rather than individual tests.

Here is the current ouput of a nose-timer run:

sklearn.tests.test_cross_validation.test_kfold_can_detect_dependent_samples_on_digits: 1.9010s
sklearn.ensemble.tests.test_bagging.test_classification: 1.6806s
sklearn.datasets.tests.test_lfw.test_load_fake_lfw_pairs: 1.5250s
sklearn.datasets.tests.test_covtype.test_fetch: 1.4943s
sklearn.gaussian_process.tests.test_gaussian_process.test_ordinary_kriging: 1.4116s
sklearn.covariance.tests.test_robust_covariance.test_mcd: 1.3144s
sklearn.datasets.tests.test_lfw.test_load_fake_lfw_people: 1.2644s
sklearn.feature_selection.tests.test_rfe.test_rfecv: 1.2322s
sklearn.ensemble.tests.test_forest.test_parallel_train: 1.1924s
sklearn.metrics.tests.test_metrics.test_sample_weight_invariance('samples_roc_auc', functools.partial(<function roc_auc_score at 0x108eca730>, average='samples'), array([[...])): 1.1434s
sklearn.feature_extraction.tests.test_image.test_connect_regions: 1.0878s
sklearn.ensemble.tests.test_gradient_boosting.test_boston: 1.0276s
test_locally_linear.test_lle_manifold: 0.9344s
...

@ogrisel
Copy link
Member Author

ogrisel commented Jul 17, 2014

@GaelVaroquaux can you please review the joblib tests removal and the test_permutation_score speedup in particular?

@ogrisel ogrisel changed the title [WIP] Make tests faster to run [MRG] Make tests faster to run Jul 17, 2014
@GaelVaroquaux
Copy link
Member

If the coverage stayed the same, I am 👍 for merge for this PR.

@arjoly
Copy link
Member

arjoly commented Jul 17, 2014

looks good

@amueller
Copy link
Member

lgtm

@ogrisel
Copy link
Member Author

ogrisel commented Jul 17, 2014

Ok I will rebase once more and merge...

ogrisel added a commit that referenced this pull request Jul 17, 2014
[MRG] Make tests faster to run
@ogrisel ogrisel merged commit 3f5e691 into scikit-learn:master Jul 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants